BUG/CLN: use more-correct isinstance check #31180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense
So are there any code paths you could see hitting this? |
|
Int64index.union(UInt64Index) I think goes through here, or the other way
around.
…On Tue, Jan 21, 2020 at 11:55 AM William Ayd ***@***.***> wrote:
Makes sense
this is only kind of a bug, since the isinstance check still returns True
on the type(obj)
So are there any code paths you could see hitting this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#31180?email_source=notifications&email_token=AB5UM6FEVW5HRSHO3VXY2U3Q65HMTA5CNFSM4KJXPFG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJRBIVA#issuecomment-576853076>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5UM6H3P6WDMGMKJ2BRHWTQ65HMTANCNFSM4KJXPFGQ>
.
|
…g-numeric-is_compat
|
does this any tests? |
no, it doesnt actually change any behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is only kind of a bug, since the isinstance check still returns True on the
type(obj)